991141 - [Follow up from Bug 956219] Look and feel for "Delete contacts" button under Settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Attachment: detail

A few inconsistencies have been detected in this implementatio. PLease see attachment for more detail.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

triage: lets fix this as part of the visual refresh work in 1.5

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

+1 to comment 1.

Just one clarification. What we are seeing is the 'select' mode, in this case 'edit mode' cause we remove. But also the list and everything is used to select contacts.

So perhaps what we have to do is modify this 'select mode' of the list to change the style to perform the common edit mode in the rest of the apps.

Thanks a lot Viky!

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

We need to make the select mode accept a parameter to change look and feel.

Also we need to address the other errors appointed by Vicky.

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

(In reply to Francisco Jordano [:arcturus] from comment #4)
> We need to make the select mode accept a parameter to change look and feel.
> 
> Also we need to address the other errors appointed by Vicky.

Franciso,
I'm working in this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=990478
Which should solve half the issues we are having here.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Arnau March  [:arnau] from comment #5)
> Franciso,
> I'm working in this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=990478
> Which should solve half the issues we are having here.

Thanks Arnau!

I'll focus on the list, and the delete button then!

Comment 7

[Maria Angeles Oteo (:oteo)]

The missalignment in the Confirmation screen that Vicky reports in the attachment 8400729 [details] will be handled in Bug 994653

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

So basically, what we have left for this bug is removing the red color of the button isnt?

Comment 9

[Noemí Freire (:noemi)]

(In reply to Francisco Jordano [:arcturus] from comment #8)
> So basically, what we have left for this bug is removing the red color of
> the button isnt?

Just to summarize what should be implemented within this bug:
1- "Delete contacts" button under settings should be grey instead of red (please refer to the third screenshot included in detail.png image)
2- "OK" button within delete confirmation message screen (please refer to the second screenshot included in detail.png image) should be red and the text should be "Delete" instead of "OK"

Moreover, 
3- The edit mode (please refer to the first screenshot included in detail.png image) will be covered in Bug 990478
4- The misalignment in the Confirmation screen (please refer to the second screenshot included in detail.png image) will be covered in Bug 994653

ni to vicky to confirm. Thanks!

Comment 10

[Victoria Gerchinhoren [:vicky]]

(In reply to Noemí Freire (:noemi) from comment #9)
> (In reply to Francisco Jordano [:arcturus] from comment #8)
> > So basically, what we have left for this bug is removing the red color of
> > the button isnt?
> 
> Just to summarize what should be implemented within this bug:
> 1- "Delete contacts" button under settings should be grey instead of red
> (please refer to the third screenshot included in detail.png image)
> 2- "OK" button within delete confirmation message screen (please refer to
> the second screenshot included in detail.png image) should be red and the
> text should be "Delete" instead of "OK"
> 
> Moreover, 
> 3- The edit mode (please refer to the first screenshot included in
> detail.png image) will be covered in Bug 990478
> 4- The misalignment in the Confirmation screen (please refer to the second
> screenshot included in detail.png image) will be covered in Bug 994653
> 
> ni to vicky to confirm. Thanks!

Perfect Noemí, thanks a lot for the summary!

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 18629

Comment 12

[Noemí Freire (:noemi)]

Finally this bug will just cover point 1 in comment 9:
1- "Delete contacts" button under settings should be grey instead of red (please refer to the third screenshot included in detail.png image)

Since point 2 in comment 9 will be covered by bug 991114:
2- "OK" button within delete confirmation message screen (please refer to the second screenshot included in detail.png image) should be red and the text should be "Delete" instead of "OK"

so changing the summary accordingly.

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Thanks Noemi, will just rebase to land that change.

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8411671 [details] [review]
Pointer to PR 18629

Changing reviewer since this change is a BB one. (A proper use of the BB)

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/arcturus/gaia/commit/68e25f08d397a07e9d38268465502da4ec6a2242